Add error handing in OrderService._place_limit_order()#119
Open
djflux wants to merge 6 commits intorhettre:mainfrom
Open
Add error handing in OrderService._place_limit_order()#119djflux wants to merge 6 commits intorhettre:mainfrom
djflux wants to merge 6 commits intorhettre:mainfrom
Conversation
This was referenced Jan 2, 2025
Owner
|
Thanks for catching this inconsistency between I'm wondering if it makes more sense to follow this solution:
Let me know what you think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of main commit 72d9e38 the code for the
_place_limit_order()method in the OrderService class inorder_service.pythrows an exception iflimit_order_gtc_[buy|sell]errors out.This pull request adds checking in
_place_limit_order()that is similar to the checking located inOrderClass.fiat_market_sell().This code has been tested with both a
fiat_limit_buyand afiat_limit_sellfor anINSUFFICIENT_FUNDcase, and provides a unit test for the new code.